Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple visual and collision elements load properly as aggregates #25

Closed
wants to merge 2 commits into from

Conversation

cpaxton
Copy link
Contributor

@cpaxton cpaxton commented Dec 6, 2017

No description provided.

Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request @cpaxton! This allows parsing <link> with multiple collision or visual. Would you mind retargeting this at the melodic-devel branch? The changes may break existing code in indigo and kinetic.

self.inertial = inertial
self.collision = collision
self.visuals = []
self.inertials = inertial
Copy link
Contributor

@sloretz sloretz Dec 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since a link may only have one <interial> tag I think this should stay as intertial

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean inertial correct?

@cpaxton
Copy link
Contributor Author

cpaxton commented Dec 19, 2017

No problem, will close and retarget.

@cpaxton cpaxton closed this Dec 19, 2017
miguelriemoliveira added a commit to afonsocastro/urdf_parser_py that referenced this pull request May 20, 2019
ros#25 first version of data collector

ros#15 and ros#21 usign a pr2 bag file downloaded from https://projects.csail.mit.edu/stata/downloads.php

ros#24 data collector is already prepared to handle dynamic transforms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants