Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new rosidl_core repository to ros2_rust_rolling.repos #251

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Conversation

nnmm
Copy link
Contributor

@nnmm nnmm commented Aug 31, 2022

The build was broken, with an error about a missing rosidl_core_generators package that is a dependency of message packages.

In ros2/rosidl_defaults#22, this package was split off from rosidl_defaults into a separate repo, which needed to be added.

I also changed the branches from 'master' to 'rolling', since they were renamed in all ROS 2 repos.

@nnmm nnmm changed the title Replace master by rolling in repos file Add new rosidl_core repository to ros2_rust_rolling.repos Aug 31, 2022
@nnmm
Copy link
Contributor Author

nnmm commented Aug 31, 2022

It appears rosidl_defaults is still needed though. Here is a job that failed when I removed it: https://github.com/ros2-rust/ros2_rust/runs/8114127304?check_suite_focus=true

@nnmm nnmm requested a review from a team August 31, 2022 13:20
@nnmm nnmm merged commit 35be7c9 into main Aug 31, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix_ci branch August 31, 2022 13:40
hoffmann-stefan added a commit to hoffmann-stefan/ros2_dotnet that referenced this pull request May 18, 2023
In ros2/rosidl_defaults#22, the rosidl_core_generators package was split off from rosidl_defaults into a separate repo, which needed to be added.
Without this repository the dotnet code for the interfaces is not generated in the workspace.

see PR on ros2-rust: ros2-rust/ros2_rust#251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants