Extend string types #293
Merged
Extend string types #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and `FromIterator<&'a char>` for String and WString ros2-rust#246
nnmm
reviewed
Nov 11, 2022
nnmm
reviewed
Nov 12, 2022
nnmm
reviewed
Nov 13, 2022
rosidl_runtime_rs/src/string.rs
Outdated
| @@ -224,6 +225,42 @@ macro_rules! string_impl { | |||
| } | |||
| } | |||
|
|
|||
| impl From<&std::string::String> for $string { | |||
There was a problem hiding this comment.
Since the existing From<&str> impl is more general, I think this impl isn't necessary.
There was a problem hiding this comment.
So in *self = Self::from(&s);, &s is actually of type &String and From isn't implemented for that type. So I removed this impl by just using Self::from(s.as_str()) in the Extend impl
There was a problem hiding this comment.
That's correct, though using Self::from(&s) should work too due to Deref coercion.
maspe36
commented
Nov 13, 2022
| @@ -126,21 +126,6 @@ macro_rules! string_impl { | |||
| ) -> bool; | |||
| } | |||
|
|
|||
| impl Default for $string { | |||
There was a problem hiding this comment.
Alphabetizing the trait impl's
nnmm
approved these changes
Nov 13, 2022
Thanks for all the guidance :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
Extend<char>,Extend<&'a char>,FromIterator<char>, andFromIterator<&'a char>for String and WString.Of note here is that with this change, String and WString now have interior mutability so they are no longer able to implement
Syncsafely.Original Issue: #246