Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend string types #293

Merged
merged 7 commits into from
Nov 13, 2022
Merged

Extend string types #293

merged 7 commits into from
Nov 13, 2022

Commits on Nov 11, 2022

  1. Implemented Extend<char>, Extend<&'a char>, FromIterator<char>,… 

    … and `FromIterator<&'a char>` for String and WString

ros2-rust#246
    @maspe36
    maspe36 committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    661558c View commit details
    Browse the repository at this point in the history

  2. Ran cargo fmt

    @maspe36
    maspe36 committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    d173928 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2022

  1. Fixed the implementation for non-ASCII characters, re-added the Sync … 

    …impl
    @maspe36
    maspe36 committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    4d5c052 View commit details
    Browse the repository at this point in the history

  2. Ran cargo format

    @maspe36
    maspe36 committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    955003a View commit details
    Browse the repository at this point in the history

  3. Simplified fn extend implementation using std::string::String's

    @maspe36
    maspe36 committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    99945e6 View commit details
    Browse the repository at this point in the history

  4. Moved implementation into the macro and just call the &str from impl

    @maspe36
    maspe36 committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    0885dd7 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2022

  1. PR feedback

    @maspe36
    maspe36 committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    55a4334 View commit details
    Browse the repository at this point in the history