Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unignore rviz tests on aarch64 repeated. #572

Merged
merged 1 commit into from
May 24, 2021

Conversation

clalancette
Copy link
Contributor

This should have been fixed long ago by
ros2/rviz#394.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

I believe that these were fixed by ros2/rviz#394 quite a while ago. Running a repeated CI job shows no failures in the rviz tests: https://ci.ros2.org/job/ci_linux-aarch64/9301/

This should have been fixed long ago by
ros2/rviz#394.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette clalancette merged commit 41c0916 into master May 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the clalancette/aarch64-unignore-rviz branch May 24, 2021 21:13
@nuclearsandwich
Copy link
Member

Just an FYI it does not seem like these changes were ever deployed as I saw this when deploying #589

Updating job 'nightly_linux-aarch64_repeated' (dry run)
    <<<
    --- remote config
    +++ new config
    @@ -167 +167 @@
    -          <defaultValue>--event-handlers console_direct+ --executor sequential --retest-until-fail 2 --ctest-args -LE "(linter|xfail)" --pytest-args -m "not linter and not xfail" --packages-skip rviz_common rviz_default_plugins rviz_rendering rviz_rendering_tests</defaultValue>
    +          <defaultValue>--event-handlers console_direct+ --executor sequential --retest-until-fail 2 --ctest-args -LE "(linter|xfail)" --pytest-args -m "not linter and not xfail"</defaultValue>
    >>>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants