Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy API #159

Closed
4 tasks done
sloretz opened this issue Jan 8, 2019 · 5 comments
Closed
4 tasks done

Remove legacy API #159

sloretz opened this issue Jan 8, 2019 · 5 comments
Assignees
@hidmic

Comments

@sloretz
Copy link
Contributor

sloretz commented Jan 8, 2019 •
edited by hidmic
Loading

The legacy API should be removed.

Places where legacy API is used 
./ros2/system_tests/test_cli_remapping/test/test_cli_remapping.py:from launch.legacy import LaunchDescriptor
./ros2/system_tests/test_cli_remapping/test/test_cli_remapping.py:from launch.legacy.exit_handler import primary_exit_handler
./ros2/system_tests/test_cli_remapping/test/test_cli_remapping.py:from launch.legacy.launcher import DefaultLauncher
./ros2/rcutils/test/test_logging_long_messages.py:from launch.legacy import LaunchDescriptor
./ros2/rcutils/test/test_logging_long_messages.py:from launch.legacy.exit_handler import ignore_exit_handler
./ros2/rcutils/test/test_logging_long_messages.py:from launch.legacy.launcher import DefaultLauncher
./ros2/rcutils/test/test_logging_long_messages.py:from launch.legacy.output_handler import ConsoleOutput
./ros2/rcutils/test/test_logging_output_format.py:from launch.legacy import LaunchDescriptor
./ros2/rcutils/test/test_logging_output_format.py:from launch.legacy.exit_handler import ignore_exit_handler
./ros2/rcutils/test/test_logging_output_format.py:from launch.legacy.launcher import DefaultLauncher
./ros2/rcutils/test/test_logging_output_format.py:from launch.legacy.output_handler import ConsoleOutput
./ros2/launch/launch_testing/launch_testing/legacy/__init__.py:from launch.legacy.output_handler import LineOutput
./ros2/launch/launch_testing/launch_testing/__init__.py:from launch_testing.legacy import create_handler  # noqa: F401
./ros2/launch/launch_testing/launch_testing/__init__.py:from launch_testing.legacy import get_default_filtered_patterns  # noqa: F401
./ros2/launch/launch_testing/launch_testing/__init__.py:from launch_testing.legacy import get_default_filtered_prefixes  # noqa: F401
./ros2/launch/launch_testing/launch_testing/__init__.py:from launch_testing.legacy import get_rmw_output_filter  # noqa: F401
./ros2/launch/launch_testing/launch_testing/__init__.py:from launch_testing.legacy import InMemoryHandler  # noqa: F401
./ros2/launch/launch_testing/launch_testing/__init__.py:from launch_testing.legacy import UnmatchedOutputError  # noqa: F401
./ros2/launch/launch_testing/test/test_env_passing.py:from launch.legacy import LaunchDescriptor
./ros2/launch/launch_testing/test/test_env_passing.py:from launch.legacy.exit_handler import primary_exit_handler
./ros2/launch/launch_testing/test/test_env_passing.py:from launch.legacy.launcher import DefaultLauncher
./ros2/launch/launch_testing/test/test_matching.py:from launch.legacy import LaunchDescriptor
./ros2/launch/launch_testing/test/test_matching.py:from launch.legacy.exit_handler import ignore_exit_handler
./ros2/launch/launch_testing/test/test_matching.py:from launch.legacy.launcher import DefaultLauncher
./ros2/launch/launch/setup.py:            'launch = launch.legacy.main:main',
./ros2/launch/launch/test/legacy/test_non_primary_return_code.py:from launch.legacy import LaunchDescriptor
./ros2/launch/launch/test/legacy/test_non_primary_return_code.py:from launch.legacy.exit_handler import primary_exit_handler
./ros2/launch/launch/test/legacy/test_non_primary_return_code.py:from launch.legacy.launcher import DefaultLauncher
./ros2/launch/launch/test/legacy/test_interrupt_default_launcher.py:from launch.legacy import LaunchDescriptor
./ros2/launch/launch/test/legacy/test_interrupt_default_launcher.py:from launch.legacy.launcher import DefaultLauncher
./ros2/launch/launch/test/legacy/test_multiple_launch.py:from launch.legacy import LaunchDescriptor
./ros2/launch/launch/test/legacy/test_multiple_launch.py:from launch.legacy.launcher import DefaultLauncher
./ros2/launch/launch/test/legacy/launch_counter.py:from launch.legacy.exit_handler import ignore_exit_handler
./ros2/launch/launch/test/legacy/launch_counter.py:from launch.legacy.output_handler import FileOutput
./ros2/launch/launch/test/legacy/test_launch_args.py:from launch.legacy.arguments import get_launch_args
./ros2/launch/launch/test/legacy/launch_multiple_counters.py:from launch.legacy import LaunchDescriptor
./ros2/launch/launch/test/legacy/launch_multiple_counters.py:from launch.legacy.exit_handler import ignore_exit_handler
./ros2/launch/launch/test/legacy/launch_multiple_counters.py:from launch.legacy.exit_handler import restart_exit_handler
./ros2/launch/launch/test/legacy/launch_multiple_counters.py:from launch.legacy.loader import load_launch_file
./ros2/launch/launch/test/legacy/launch_multiple_counters.py:from launch.legacy.output_handler import ConsoleOutput
./ros2/launch/launch/test/legacy/launch_multiple_counters.py:from launch.legacy.output_handler import FileOutput
./ros2/launch/launch/test/legacy/test_launch_with_coroutine.py:from launch.legacy import LaunchDescriptor
./ros2/launch/launch/test/legacy/test_launch_with_coroutine.py:from launch.legacy.exit_handler import primary_exit_handler
./ros2/launch/launch/test/legacy/test_launch_with_coroutine.py:from launch.legacy.launcher import DefaultLauncher
./ros2/launch/launch/test/legacy/test_launch_with_coroutine.py:from launch.legacy.loader import load_launch_file
./ros2/launch/launch/launch/legacy/launcher.py:from launch.legacy.exit_handler import ExitHandlerContext
./ros2/launch/launch/launch/legacy/launcher.py:from launch.legacy.launch import LaunchState
./ros2/launch/launch/launch/legacy/launcher.py:from launch.legacy.protocol import SubprocessProtocol
./ros2/launch/launch/launch/legacy/launcher.py:from launch.legacy.task import TaskState
./ros2/launch/launch/launch/legacy/main.py:from launch.legacy import LaunchDescriptor
./ros2/launch/launch/launch/legacy/main.py:from launch.legacy.launcher import DefaultLauncher
./ros2/launch/launch/launch/legacy/main.py:from launch.legacy.loader import load_launch_file
./ros2/launch/launch/launch/legacy/__init__.py:from launch.legacy.exit_handler import default_exit_handler
./ros2/launch/launch/launch/legacy/__init__.py:from launch.legacy.output_handler import CompositeOutputHandler
./ros2/launch/launch/launch/legacy/__init__.py:from launch.legacy.output_handler import ConsoleOutput
./ros2/launch/launch/launch/__init__.py:from . import legacy
./ros2/launch/launch/launch/__init__.py:    'legacy',

Packages to update

  • test_cli_remapping
  • rcutils
  • launch_testing
  • launch
@sloretz sloretz added the ready Work is about to start (Kanban column) label Jan 8, 2019
@hidmic hidmic mentioned this issue Jan 15, 2019
Closed
@dirk-thomas dirk-thomas mentioned this issue Jan 22, 2019
Closed
20 tasks
@hidmic hidmic mentioned this issue Jan 29, 2019
Merged
@tfoote tfoote added in progress Actively being worked on (Kanban column) and removed ready Work is about to start (Kanban column) labels Jan 29, 2019
This was referenced Jan 29, 2019
Merged
Merged
@hidmic hidmic added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jan 31, 2019
@hidmic
Copy link
Contributor

hidmic commented Feb 7, 2019 •
edited
Loading

Well, this ended up being much more work than expected. Above list isn't exhaustive: it's missing all the *.py.in files that make use of the legacy launch API.

Remaining packages to update

  • rcl
  • composition
  • demo_nodes_cpp
  • demo_nodes_cpp_native
  • image_tools
  • intraprocess_demo
  • logging_demo
  • pendulum_control
  • test_security
  • test_communication
  • test_rclcpp
  • ros1_bridge

@ivanpauno ivanpauno mentioned this issue Feb 7, 2019
Merged
This was referenced Feb 8, 2019
Merged
Merged
Merged
@mjcarroll mjcarroll removed the in review Waiting for review (Kanban column) label Feb 28, 2019
@hidmic
Copy link
Contributor

hidmic commented Feb 28, 2019

Do we want to remove any trace of the legacy API too? @mjcarroll @dirk-thomas

@mjcarroll
Copy link
Member

I think since nothing is using it, it's safe to drop. Sorry, I thought that was part of the previous PR here, so I closed the issue. If we need to, we can reopen to track this.

This was referenced Mar 11, 2019
Merged
Merged
@hidmic
Copy link
Contributor

hidmic commented Mar 11, 2019 •
edited
Loading

Alright, legacy launch API completely deprecated removed after #191. Dashing release changelist reflects this after ros2/ros2_documentation#135.

@dirk-thomas
Copy link
Member

legacy launch API completely deprecated

The legacy API has been removed - not being deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hidmic hidmic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mjcarroll @tfoote @dirk-thomas @sloretz @hidmic