Update Dashing Diademata changelist after legacy launch deprecation. #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
Some information what users should use instead would be helpful. |
…ation. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
dirk-thomas
reviewed
Mar 6, 2019
| The ``launch_testing`` package caught up with the ``launch`` package redesign done in Bouncy Bolson. | ||
| The legacy Python API, already moved into the ``launch.legacy`` submodule, has thus been deprecated and removed. | ||
|
|
||
| See ``launch`` `examples <https://github.com/ros2/launch/tree/master/launch/examples>`__ and `documentation <https://github.com/ros2/launch/tree/master/launch/doc>`__ for reference on how to use its new API. |
There was a problem hiding this comment.
The URL will need to be updated to point to the dashing branch ones that is created.
There was a problem hiding this comment.
Yes, I know. Do we have a place to list future TODOs?
dirk-thomas
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precisely what the title says. Connected to ros2/launch#191 and ros2/launch#159.