Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dashing Diademata changelist after legacy launch deprecation. #135

Merged
merged 2 commits into from
Mar 6, 2019
Merged

Update Dashing Diademata changelist after legacy launch deprecation. #135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43f5c74
Update Dashing Diademata changelist after legacy launch deprecation.
hidmic Mar 6, 2019
3d0cbdf
Add references to examples, tests and docs after legacy launch deprec…
hidmic Mar 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions source/Releases/Release-Dashing-Diademata.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,16 @@ you need to update the condition to ensure it considers a string value as ``TRUE

if(var)

launch
~~~~~~

The ``launch_testing`` package caught up with the ``launch`` package redesign done in Bouncy Bolson.
The legacy Python API, already moved into the ``launch.legacy`` submodule, has thus been deprecated and removed.

See ``launch`` `examples <https://github.com/ros2/launch/tree/master/launch/examples>`__ and `documentation <https://github.com/ros2/launch/tree/master/launch/doc>`__ for reference on how to use its new API.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL will need to be updated to point to the dashing branch ones that is created.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I know. Do we have a place to list future TODOs?


See `demos tests <https://github.com/ros2/demos>`__ for reference on how to use the new ``launch_testing`` API.

rmw
~~~

Expand Down