Drop legacy launch package #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
wjwwood
approved these changes
Feb 28, 2019
hidmic
added
in review
|
Running CI again:
|
|
@wjwwood tests failures are unrelated. |
|
Please add information about this to the migration section of the Dashing release page. |
|
@dirk-thomas where's that section? Or should I add one? |
|
Any objection to get this one merged? It looks like |
|
No complaints from me. |
mjcarroll
approved these changes
Mar 6, 2019
https://index.ros.org/doc/ros2/Releases/Release-Dashing-Diademata/#changes-since-the-crystal-release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up after #167. Connected to #159. Drops legacy launch code entirely.
Signed-off-by: Michel Hidalgo michel@ekumenlabs.com