Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct launch service sigterm handling #294

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

ivanpauno
Copy link
Member

It may be related with ros2/demos#354

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label Aug 2, 2019
@ivanpauno ivanpauno requested a review from hidmic August 2, 2019 15:29
@ivanpauno ivanpauno self-assigned this Aug 2, 2019
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI

launch/launch/launch_service.py Show resolved Hide resolved
@ivanpauno
Copy link
Member Author

ivanpauno commented Aug 2, 2019

CI up to launch, launch_xml, launch_yaml, launch_ros, test_launch_ros (only fastrtps):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status (unrelated failure)

@ivanpauno ivanpauno merged commit 3900dfe into master Aug 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/fix-on-sigterm branch August 5, 2019 17:11
piraka9011 pushed a commit to aws-ros-dev/launch that referenced this pull request Aug 16, 2019
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in review Waiting for review (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants