Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make namespace parameter mandatory in LifecycleNode constructor #157

Merged
merged 8 commits into from
Jun 25, 2020
Merged

Make namespace parameter mandatory in LifecycleNode constructor #157

merged 8 commits into from
Jun 25, 2020

Commits on Jun 23, 2020

  1. Fix namespace parameter in LifecycleNode 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    c1406bb View commit details
    Browse the repository at this point in the history

  2. Fix new test 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    15fe7b5 View commit details
    Browse the repository at this point in the history

  3. Address peer review comment 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    006a5b8 View commit details
    Browse the repository at this point in the history

  4. Update example 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    817ebd7 View commit details
    Browse the repository at this point in the history

  5. Please linters 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    368a0af View commit details
    Browse the repository at this point in the history

  6. Cover LifecycleNode in the tests 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    a9e4c10 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2020

  1. Fix errors 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    4253a34 View commit details
    Browse the repository at this point in the history

  2. Correct comments 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    620801e View commit details
    Browse the repository at this point in the history