Make namespace parameter mandatory in LifecycleNode constructor #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
sloretz
reviewed
Jun 23, 2020
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
sloretz
added a commit
to ros2/demos
that referenced
this pull request
Jun 23, 2020
Fixes regression introduced by ros2/launch_ros#153 Alternative to ros2/launch_ros#157
sloretz
added a commit
to ros2/demos
that referenced
this pull request
Jun 23, 2020
Fixes regression introduced by ros2/launch_ros#153 Alternative to ros2/launch_ros#157 Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
sloretz
reviewed
Jun 23, 2020
sloretz
reviewed
Jun 23, 2020
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
sloretz
reviewed
Jun 23, 2020
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
hidmic
approved these changes
Jun 24, 2020
test_launch_ros/test/test_launch_ros/actions/test_lifecycle_node.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
|
hidmic
approved these changes
Jun 25, 2020
ivanpauno
changed the title
ivanpauno
changed the title
|
I looked it over just now. I think it was fine as-is. |
jacobperron
pushed a commit
that referenced
this pull request
Sep 18, 2020
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron
added a commit
that referenced
this pull request
Oct 5, 2020
* Fix no specified namespace (#153) Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> * Make namespace parameter mandatory in LifecycleNode constructor (#157) Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> * Make namespace argument optional This maintains backwards compatibility. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Remove test for construction without namespace Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Treat empty namespace as unset This keeps the current behavior in Foxy. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Address feedback and fix bug in LifecycleNode If no namespace (or empty string) is provided, assume global namespace. Signed-off-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#153 introduced some regressions in nightlies:
https://ci.ros2.org/view/nightly/job/nightly_linux_release/1582/testReport/junit/(root)/projectroot/test_test_lifecycle_py/
https://ci.ros2.org/view/nightly/job/nightly_linux_release/1582/testReport/junit/lifecycle/TestLifecyclePubSub/test_talker_lifecycle/
https://ci.ros2.org/view/nightly/job/nightly_linux_release/1582/testReport/junit/lifecycle/TestLifecyclePubSubAfterShutdown/test_talker_graceful_shutdown/
The problem isn't #153 IMO.
The problem is that we were assuming that the node fqn name is known, even when we were not passing a
__nsremapping rule (if the executable used a namespace different to/and a namespace wasn't being passed explicitly, LifecycleNode action was already broken).There are two options:
/(overriding whatever was specified in the executable).I prefer the first option.
This is implementing the second option, as the first requires multiple PRs in other repos.