Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing required parameter in LifecycleNode launch action #456

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Add missing required parameter in LifecycleNode launch action #456

merged 1 commit into from
Jun 23, 2020

Conversation

ivanpauno
Copy link
Member

@ivanpauno
Add missing required parameter in LifecycleNode launch action
1137efd 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label Jun 23, 2020
@ivanpauno ivanpauno requested a review from hidmic June 23, 2020 17:41
@ivanpauno ivanpauno self-assigned this Jun 23, 2020
@sloretz sloretz mentioned this pull request Jun 23, 2020
Closed
@ivanpauno ivanpauno mentioned this pull request Jun 23, 2020
Merged
@ivanpauno
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno
Copy link
Member Author

@ros-pull-request-builder retest this please

@ivanpauno ivanpauno merged commit b6b2910 into master Jun 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/fix-lifecycle-node branch June 23, 2020 20:14
@Tiryoh Tiryoh mentioned this pull request Nov 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

@hidmic hidmic Awaiting requested review from hidmic

Assignees

@ivanpauno ivanpauno

Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanpauno @sloretz