Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement matched event #1033

Merged

Conversation

Barry-Xu-2018
Copy link
Contributor

Address ros2/rmw#330

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm, but i believe one test case should be added as following.

rcl/test/rcl/test_events.cpp Outdated Show resolved Hide resolved
rcl/test/rcl/test_events.cpp Outdated Show resolved Hide resolved
@Barry-Xu-2018 Barry-Xu-2018 force-pushed the topic-add-matched-unmatched-event-support branch from c8b7fdc to 1d73a00 Compare March 6, 2023 04:45
@Barry-Xu-2018
Copy link
Contributor Author

Rebase was done.

Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
…llback

Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
@Barry-Xu-2018 Barry-Xu-2018 force-pushed the topic-add-matched-unmatched-event-support branch from 1d73a00 to 4052b24 Compare March 16, 2023 12:25
@Barry-Xu-2018 Barry-Xu-2018 changed the title Add matched & unmatched event support Implement matched event Mar 17, 2023
Signed-off-by: Barry Xu <barry.xu@sony.com>
@mjcarroll mjcarroll merged commit fae1a01 into ros2:rolling Mar 22, 2023
danthony06 pushed a commit to danthony06/rcl that referenced this pull request Jun 14, 2023
Signed-off-by: Barry Xu <barry.xu@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants