Removed deprecated localhost_only #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
|
friendly ping @fujitatomoya |
|
@ahcorde sorry for being late, but this is under my radar. let me have a couple of days! |
This was referenced Jul 26, 2024
fujitatomoya
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
looks good to me as rcl, the following rmw implementation PRs to remove member variable aligns with this PR.
- remove rmw_localhost_only_t. rmw#376
- remove rmw_localhost_only_t. rmw_implementation#239
- remove rmw_localhost_only_t. rmw_fastrtps#773
- remove rmw_localhost_only_t. rmw_connextdds#156
- remove rmw_localhost_only_t. rmw_cyclonedds#508
No documentation required to change, https://docs.ros.org/en/rolling/Tutorials/Advanced/Improved-Dynamic-Discovery.html already explains well.
| @@ -293,29 +293,6 @@ TEST(TestDiscoveryInfo, test_with_localhost_only) { | |||
| } | |||
|
|
|||
| { | |||
| // Only ROS_LOCALHOST_ONLY is enabled | |||
There was a problem hiding this comment.
I think we can also remove the comments on this test.
|
@ahcorde can you take a look at related rmw PRs? just removing the |
|
Running full CI, included all PRs
|
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method
rcl_get_localhost_only(rmw_localhost_only_t * localhost_only);was not deprecated, not sure if we can remove this.This is deprecated at least since
iron