Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetTypeDescription.srv (rep2011) #153

Merged
merged 9 commits into from
Mar 23, 2023
Merged

Add GetTypeDescription.srv (rep2011) #153

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2cbbd21
Add GetTypeDescription.srv
emersonknapp Feb 24, 2023
fb7a19c
Add format clarification comments and fix formatting
emersonknapp Mar 10, 2023
6f8d286
Update service from design discussion
emersonknapp Mar 15, 2023
71c97ae
Fix unfinished thought and clarify comments from review
emersonknapp Mar 16, 2023
6756fdb
Type raw sources in a list of submessages
emersonknapp Mar 22, 2023
c5998a7
Use type_hash instead of type_version_hash
emersonknapp Mar 22, 2023
2ec42ec
Update to cpp17 while we are here, like the rest of the pkgs in the repo
emersonknapp Mar 22, 2023
1db9478
Update encoding information and resulting logical updates
emersonknapp Mar 22, 2023
a2b4f4e
Add better documentation for TypeSource
emersonknapp Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions type_description_interfaces/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ rosidl_generate_interfaces(${PROJECT_NAME}
"msg/FieldType.msg"
"msg/IndividualTypeDescription.msg"
"msg/TypeDescription.msg"
"srv/GetTypeDescription.srv"
ADD_LINTER_TESTS
)

Expand Down
1 change: 1 addition & 0 deletions type_description_interfaces/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<buildtool_depend>ament_cmake</buildtool_depend>

<buildtool_depend>rosidl_core_generators</buildtool_depend>
<depend>service_msgs</depend>

<exec_depend>rosidl_core_runtime</exec_depend>

emersonknapp marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
19 changes: 19 additions & 0 deletions type_description_interfaces/srv/GetTypeDescription.srv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
string type_name
string type_version_hash
clalancette marked this conversation as resolved.
Show resolved Hide resolved
---
# True if the type description information is available and populated in the response
emersonknapp marked this conversation as resolved.
Show resolved Hide resolved
bool successful
# Empty if 'successful' was true, otherwise contains details on why it failed
emersonknapp marked this conversation as resolved.
Show resolved Hide resolved
string failure_reason
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this to reason instead of failure_reason.

Copy link

@achim-k achim-k Mar 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something went wrong here, this became failure_reason again (1db9478)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that might have been intentional since it's no longer multi purpose? I'm not sure I haven't re-reviewed this yet.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, changed back on purpose, see #153 (comment)


# The idl or msg file name
string type_description_raw_file_name
# The idl or msg file, with comments and whitespace
# The file extension and/or the contents can be used to determine the format
string type_description_raw
emersonknapp marked this conversation as resolved.
Show resolved Hide resolved
emersonknapp marked this conversation as resolved.
Show resolved Hide resolved
# The parsed type description which can be used programmatically
TypeDescription type_description

# Key-value pairs of extra information.
string[] extra_information_keys
string[] extra_information_values
emersonknapp marked this conversation as resolved.
Show resolved Hide resolved