SubscriptionBase::get_subscription_handle() const should return a s…

…hared pointer to const value (#1140) Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ros2 · May 28, 2020 · 40e8b01 · 40e8b01
1 parent c9c4253
commit 40e8b01
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/rclcpp/include/rclcpp/subscription_base.hpp b/rclcpp/include/rclcpp/subscription_base.hpp
@@ -91,7 +91,7 @@ class SubscriptionBase : public std::enable_shared_from_this<SubscriptionBase>
   get_subscription_handle();
 
   RCLCPP_PUBLIC
-  const std::shared_ptr<rcl_subscription_t>
+  std::shared_ptr<const rcl_subscription_t>
   get_subscription_handle() const;
 
   /// Get all the QoS event handlers associated with this subscription.

diff --git a/rclcpp/src/rclcpp/subscription_base.cpp b/rclcpp/src/rclcpp/subscription_base.cpp
@@ -109,7 +109,7 @@ SubscriptionBase::get_subscription_handle()
   return subscription_handle_;
 }
 
-const std::shared_ptr<rcl_subscription_t>
+std::shared_ptr<const rcl_subscription_t>
 SubscriptionBase::get_subscription_handle() const
 {
   return subscription_handle_;