Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate set_on_parameters_set_callback #791

Closed
ivanpauno opened this issue Jul 24, 2019 · 0 comments · Fixed by #1123
Closed

Deprecate set_on_parameters_set_callback #791

ivanpauno opened this issue Jul 24, 2019 · 0 comments · Fixed by #1123
Assignees
@claireyywang
Labels
enhancement New feature or request in progress Actively being worked on (Kanban column)

Comments

@ivanpauno
Copy link
Member

Feature request

Feature description

In #772, new methods that allow registering multiple callbacks were added.
The old set_on_parameters_set_callback should be deprecated.
@ivanpauno ivanpauno added the enhancement New feature or request label Jul 24, 2019
@ivanpauno ivanpauno mentioned this issue Aug 20, 2019
Closed
@allenh1 allenh1 mentioned this issue Nov 21, 2019
Merged
@jacobperron jacobperron mentioned this issue Jan 29, 2020
Closed
@claireyywang claireyywang self-assigned this Mar 26, 2020
@claireyywang claireyywang added the ready Work is about to start (Kanban column) label Apr 2, 2020
@claireyywang claireyywang added in progress Actively being worked on (Kanban column) and removed ready Work is about to start (Kanban column) labels May 19, 2020
@claireyywang claireyywang added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels May 21, 2020
@claireyywang claireyywang mentioned this issue May 21, 2020
Merged
@claireyywang claireyywang added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels May 21, 2020
nnmm pushed a commit to ApexAI/rclcpp that referenced this issue Jul 9, 2022
calling fini functions to avoid memory leak (ros2#791)
78ed316 
* Fix test memory leaks

1.  calling rcutils_string_map_fini to avoid memory leak
2.  Fix memory leak that not to call rcutils_string_array_fini for enclaves
3.  Fix that not to rcutils_string_array_fini for node_names_2 and node_namespaces_2
4.  Fix that not to rcl_log_levels_fini for copied_log_levels
5.  Fix that not to call rmw_security_options_fini for options
6.  Call test_msgs__srv__BasicTypes_Request__fini for service_request in the end

Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claireyywang claireyywang

Labels
enhancement New feature or request in progress Actively being worked on (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate set_on_parameters_set_callback ros2/rclcpp
2 participants
@claireyywang @ivanpauno