Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dnae adas/generic subscriber and publisher #1077

Open
wants to merge 25 commits into
base: rolling
Choose a base branch
from
Open

Dnae adas/generic subscriber and publisher #1077

wants to merge 25 commits into from

Commits on Apr 22, 2020

  1. * updated interface to SubscriptionIntraProcessBase 

    * implemented interface to deserialize a given serialized message to ros message

Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    9d88f0e View commit details
    Browse the repository at this point in the history

  2. added support for SerializedMessage in Intraprocessmanger, so: 

     * serialized publisher uses correct method to forward content to subscriber
 * non-serialized publisher can serialize message for serialized subscriber

Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    1dad3ad View commit details
    Browse the repository at this point in the history

  3. updated unit test for intraprocess manager to match new interface 

    Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    c552c0b View commit details
    Browse the repository at this point in the history

  4. updated is_serialized_message_class traits 

    Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    2513cc2 View commit details
    Browse the repository at this point in the history

  5. renamed provide_serialized_intra_process_message to provide_intra_pro… 

    …cess_message

Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    fd6a20e View commit details
    Browse the repository at this point in the history

  6. fixed Serialization class for non-supported type (yes this is actuall… 

    …y needed for the next PR)

Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    f0c8dd3 View commit details
    Browse the repository at this point in the history

  7. updated to (de)seriaizle method 

    Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    facb43d View commit details
    Browse the repository at this point in the history

  8. fix build regression (ros2#1078) 

    Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
    @dirk-thomas
    dirk-thomas authored and Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    08a3251 View commit details
    Browse the repository at this point in the history

  9. Reflect changes in rclcpp API (ros2#1079) 

    * Reflect changes in rclcpp API

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Revert earlier fix made in rclcpp

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
    Prajakta Gokhale authored and Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    0577f39 View commit details
    Browse the repository at this point in the history

  10. extended publisher: 

     * added constructor with typesupport
 * added more generic do_inter_process_publish

Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    9ae2da1 View commit details
    Browse the repository at this point in the history

  11. added create_generic_subscription and create_generic_publisher 

    Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    9490d9f View commit details
    Browse the repository at this point in the history

  12. added test for intra process communication with generic publishers an… 

    …d subscribers

Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    3b430bf View commit details
    Browse the repository at this point in the history

  13. fixed date 

    Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    88a6927 View commit details
    Browse the repository at this point in the history

  14. fixed unintended change 

    Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    63ad2fe View commit details
    Browse the repository at this point in the history

  15. replaced generic_publisher 

    Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    86f8ef9 View commit details
    Browse the repository at this point in the history

  16. removed unneeded template typename 

    Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    62635ab View commit details
    Browse the repository at this point in the history

  17. renamed create_generic_... to create_ 

    Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    d676d12 View commit details
    Browse the repository at this point in the history

  18. updated to new SerializedMessage 

    Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    aeb69bf View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2020

  1. * added get_type_support_handle to rclcpp::Serialization 

    * removed specialization to rclcpp::Serialization

Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    8d2de84 View commit details
    Browse the repository at this point in the history

  2. extended subscription_intra_process(_base): 

     * allocate message
 * getter for serialization
 * provide untyped message

Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    e2c19bb View commit details
    Browse the repository at this point in the history

  3. update unit test for subscription_intra_process(_base) 

    Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    370061b View commit details
    Browse the repository at this point in the history

  4. extended intra_process_manager for serialized messages: 

     * two extra subscription/publisher pairs (for serialized ones)
 * added methods for (de)serialization
 * added methods for messages without known allocator
 * splitted up publishing with same type and not matching message type

Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    50334ba View commit details
    Browse the repository at this point in the history

  5. simplified code 

    Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    2e5a7bd View commit details
    Browse the repository at this point in the history

  6. fixed modifier 

    Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    6b3d9c7 View commit details
    Browse the repository at this point in the history

  7. updated comments 

    Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    f5c3362 View commit details
    Browse the repository at this point in the history