-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dnae adas/generic subscriber and publisher #1077
Open
DensoADAS
wants to merge
25
commits into
ros2:rolling
Choose a base branch
from
DensoADAS:dnae_adas/generic_subscriber_and_publisher
base: rolling
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
9d88f0e
* updated interface to SubscriptionIntraProcessBase
1dad3ad
added support for SerializedMessage in Intraprocessmanger, so:
c552c0b
updated unit test for intraprocess manager to match new interface
2513cc2
updated is_serialized_message_class traits
fd6a20e
renamed provide_serialized_intra_process_message to provide_intra_pro…
f0c8dd3
fixed Serialization class for non-supported type (yes this is actuall…
facb43d
updated to (de)seriaizle method
08a3251
fix build regression (#1078)
dirk-thomas 0577f39
Reflect changes in rclcpp API (#1079)
9ae2da1
extended publisher:
9490d9f
added create_generic_subscription and create_generic_publisher
3b430bf
added test for intra process communication with generic publishers an…
88a6927
fixed date
63ad2fe
fixed unintended change
86f8ef9
replaced generic_publisher
62635ab
removed unneeded template typename
d676d12
renamed create_generic_... to create_
aeb69bf
updated to new SerializedMessage
8d2de84
* added get_type_support_handle to rclcpp::Serialization
e2c19bb
extended subscription_intra_process(_base):
370061b
update unit test for subscription_intra_process(_base)
50334ba
extended intra_process_manager for serialized messages:
2e5a7bd
simplified code
6b3d9c7
fixed modifier
f5c3362
updated comments
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why both
MessageT
template parameter and thetype_support
argument are needed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming should also be more clear.
Maybe, just an override of
create_publisher
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think MessageT is used for the allocator