Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate set_on_parameters_set_callback #1123

Merged
merged 25 commits into from
May 27, 2020
Merged

Deprecate set_on_parameters_set_callback #1123

merged 25 commits into from
May 27, 2020
+77 −22

Commits on May 20, 2020

  1. add deprecate statement 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang committed May 20, 2020
    Configuration menu
    Copy the full SHA
    7ea9978 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2020

  1. replace tests to use add_on_param fn 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang committed May 21, 2020
    Configuration menu
    Copy the full SHA
    f6dc89e View commit details
    Browse the repository at this point in the history

  2. deprecate set_on_pram fn in node_parameters 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang committed May 21, 2020
    Configuration menu
    Copy the full SHA
    4640360 View commit details
    Browse the repository at this point in the history

  3. deprecate in lifecycle_node and add replacement fn 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang committed May 21, 2020
    Configuration menu
    Copy the full SHA
    2f78102 View commit details
    Browse the repository at this point in the history

  4. replace set_on_param 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang committed May 21, 2020
    Configuration menu
    Copy the full SHA
    f4837e8 View commit details
    Browse the repository at this point in the history

  5. deref shared_ptr 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang committed May 21, 2020
    Configuration menu
    Copy the full SHA
    2bd8006 View commit details
    Browse the repository at this point in the history

  6. deref ptrs 2 try 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang committed May 21, 2020
    Configuration menu
    Copy the full SHA
    de49681 View commit details
    Browse the repository at this point in the history

  7. correct typo in lifecycle node 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang committed May 21, 2020
    Configuration menu
    Copy the full SHA
    c63ddf4 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2020

  1. correct type in rclcpp_lifecyclenode 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang committed May 22, 2020
    Configuration menu
    Copy the full SHA
    a0ba91b View commit details
    Browse the repository at this point in the history

  2. update documentation 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang committed May 22, 2020
    Configuration menu
    Copy the full SHA
    3187942 View commit details
    Browse the repository at this point in the history

  3. add warning suppression to test_node.cpp 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang committed May 22, 2020
    Configuration menu
    Copy the full SHA
    ba8e395 View commit details
    Browse the repository at this point in the history

  4. correct namespace in lifecycle_node.cpp 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang committed May 22, 2020
    Configuration menu
    Copy the full SHA
    5f72b50 View commit details
    Browse the repository at this point in the history

  5. remove whitespace 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang committed May 22, 2020
    Configuration menu
    Copy the full SHA
    4faa099 View commit details
    Browse the repository at this point in the history

  6. fix line length in lifecycle_node 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang committed May 22, 2020
    Configuration menu
    Copy the full SHA
    193a07d View commit details
    Browse the repository at this point in the history

Commits on May 26, 2020

  1. fix deprecate typo 

    Signed-off-by: claireyywang <clairewang96@gmail.com>
    @claireyywang
    claireyywang committed May 26, 2020
    Configuration menu
    Copy the full SHA
    a5220c6 View commit details
    Browse the repository at this point in the history

  2. remove add_on and remove_on fns 

    Signed-off-by: claireyywang <clairewang96@gmail.com>
    @claireyywang
    claireyywang committed May 26, 2020
    Configuration menu
    Copy the full SHA
    e937b50 View commit details
    Browse the repository at this point in the history

  3. move reset fn to below add_on 

    Signed-off-by: claireyywang <clairewang96@gmail.com>
    @claireyywang
    claireyywang committed May 26, 2020
    Configuration menu
    Copy the full SHA
    3f9819f View commit details
    Browse the repository at this point in the history

  4. correct deprecated typo 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang committed May 26, 2020
    Configuration menu
    Copy the full SHA
    4e1951a View commit details
    Browse the repository at this point in the history

  5. correct another deprecate typo 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang committed May 26, 2020
    Configuration menu
    Copy the full SHA
    339f119 View commit details
    Browse the repository at this point in the history

  6. correct typo 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang committed May 26, 2020
    Configuration menu
    Copy the full SHA
    9969c54 View commit details
    Browse the repository at this point in the history

  7. deprecate set_on in test_lifecycle_node 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang committed May 26, 2020
    Configuration menu
    Copy the full SHA
    713191e View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into claire/deprecate_set_on_param_fn

    @claireyywang
    claireyywang committed May 26, 2020
    Configuration menu
    Copy the full SHA
    7796902 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into claire/deprecate_set_on_param_fn

    @claireyywang
    claireyywang committed May 26, 2020
    Configuration menu
    Copy the full SHA
    b6b7d3d View commit details
    Browse the repository at this point in the history

  10. suppress deprecation warning in node.cpp 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang committed May 26, 2020
    Configuration menu
    Copy the full SHA
    8c5666c View commit details
    Browse the repository at this point in the history

  11. suppress warning in lifecycle_node.cpp 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang committed May 26, 2020
    Configuration menu
    Copy the full SHA
    3bc9cfc View commit details
    Browse the repository at this point in the history