Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase rclcpp_action test coverage #1153

Merged
merged 4 commits into from
Jun 8, 2020
Merged

Increase rclcpp_action test coverage #1153

merged 4 commits into from
Jun 8, 2020

Commits on Jun 2, 2020

  1. Do not leak memory on action client/server destruction. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    5a722d4 View commit details
    Browse the repository at this point in the history

  2. Improve rclcpp_action test coverage. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    dcff3d8 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2020

  1. Correct typos in comments. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    c19ba06 View commit details
    Browse the repository at this point in the history

  2. Address peer review comments. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    7ba3914 View commit details
    Browse the repository at this point in the history