-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert rcl_params_t to ParameterMap #485
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
// Copyright 2018 Open Source Robotics Foundation, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
#ifndef RCLCPP__PARAMETER_MAP_HPP_ | ||
#define RCLCPP__PARAMETER_MAP_HPP_ | ||
|
||
#include <rcl_yaml_param_parser/types.h> | ||
|
||
#include <string> | ||
#include <unordered_map> | ||
#include <vector> | ||
|
||
#include "rclcpp/exceptions.hpp" | ||
#include "rclcpp/parameter.hpp" | ||
#include "rclcpp/parameter_value.hpp" | ||
#include "rclcpp/visibility_control.hpp" | ||
|
||
namespace rclcpp | ||
{ | ||
|
||
/// A map of fully qualified node names to a list of parameters | ||
using ParameterMap = std::unordered_map<std::string, std::vector<Parameter>>; | ||
|
||
/// Convert parameters from rcl_yaml_param_parser into C++ class instances. | ||
/// \param[in] c_params C structures containing parameters for multiple nodes. | ||
/// \returns a map where the keys are fully qualified node names and values a list of parameters. | ||
/// \throws InvalidParametersException if the `rcl_params_t` is inconsistent or invalid. | ||
RCLCPP_PUBLIC | ||
ParameterMap | ||
parameter_map_from(const rcl_params_t * const c_params); | ||
|
||
/// Convert parameter value from rcl_yaml_param_parser into a C++ class instance. | ||
/// \param[in] c_value C structure containing a value of a parameter. | ||
/// \returns an instance of a parameter value | ||
/// \throws InvalidParameterValueException if the `rcl_variant_t` is inconsistent or invalid. | ||
RCLCPP_PUBLIC | ||
ParameterValue | ||
parameter_value_from(const rcl_variant_t * const c_value); | ||
|
||
} // namespace rclcpp | ||
|
||
#endif // RCLCPP__PARAMETER_MAP_HPP_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,128 @@ | ||
// Copyright 2018 Open Source Robotics Foundation, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
#include <string> | ||
#include <vector> | ||
|
||
#include "rclcpp/parameter_map.hpp" | ||
|
||
using rclcpp::exceptions::InvalidParametersException; | ||
using rclcpp::exceptions::InvalidParameterValueException; | ||
using rclcpp::ParameterMap; | ||
using rclcpp::ParameterValue; | ||
|
||
ParameterMap | ||
rclcpp::parameter_map_from(const rcl_params_t * const c_params) | ||
{ | ||
if (NULL == c_params) { | ||
throw InvalidParametersException("parameters struct is NULL"); | ||
} else if (NULL == c_params->node_names) { | ||
throw InvalidParametersException("node names array is NULL"); | ||
} else if (NULL == c_params->params) { | ||
throw InvalidParametersException("node params array is NULL"); | ||
} | ||
|
||
// Convert c structs into a list of parameters to set | ||
ParameterMap parameters; | ||
for (size_t n = 0; n < c_params->num_nodes; ++n) { | ||
const char * c_node_name = c_params->node_names[n]; | ||
if (NULL == c_node_name) { | ||
throw InvalidParametersException("Node name at index " + std::to_string(n) + " is NULL"); | ||
} | ||
|
||
/// make sure there is a leading slash on the fully qualified node name | ||
std::string node_name("/"); | ||
if ('/' != c_node_name[0]) { | ||
node_name += c_node_name; | ||
} else { | ||
node_name = c_node_name; | ||
} | ||
|
||
const rcl_node_params_t * const c_params_node = &(c_params->params[n]); | ||
|
||
std::vector<Parameter> & params_node = parameters[node_name]; | ||
params_node.reserve(c_params_node->num_params); | ||
|
||
for (size_t p = 0; p < c_params_node->num_params; ++p) { | ||
const char * const c_param_name = c_params_node->parameter_names[p]; | ||
if (NULL == c_param_name) { | ||
std::string message( | ||
"At node " + std::to_string(n) + " parameter " + std::to_string(p) + " name is NULL"); | ||
throw InvalidParametersException(message); | ||
} | ||
const rcl_variant_t * const c_param_value = &(c_params_node->parameter_values[p]); | ||
params_node.emplace_back(c_param_name, parameter_value_from(c_param_value)); | ||
} | ||
} | ||
return parameters; | ||
} | ||
|
||
ParameterValue | ||
rclcpp::parameter_value_from(const rcl_variant_t * const c_param_value) | ||
{ | ||
if (NULL == c_param_value) { | ||
throw InvalidParameterValueException("Passed argument is NULL"); | ||
} | ||
if (c_param_value->bool_value) { | ||
return ParameterValue(*(c_param_value->bool_value)); | ||
} else if (c_param_value->integer_value) { | ||
return ParameterValue(*(c_param_value->integer_value)); | ||
} else if (c_param_value->double_value) { | ||
return ParameterValue(*(c_param_value->double_value)); | ||
} else if (c_param_value->string_value) { | ||
return ParameterValue(std::string(c_param_value->string_value)); | ||
} else if (c_param_value->byte_array_value) { | ||
const rcl_byte_array_t * const byte_array = c_param_value->byte_array_value; | ||
std::vector<uint8_t> bytes; | ||
bytes.reserve(byte_array->size); | ||
for (size_t v = 0; v < byte_array->size; ++v) { | ||
bytes.push_back(byte_array->values[v]); | ||
} | ||
return ParameterValue(bytes); | ||
} else if (c_param_value->bool_array_value) { | ||
const rcl_bool_array_t * const bool_array = c_param_value->bool_array_value; | ||
std::vector<bool> bools; | ||
bools.reserve(bool_array->size); | ||
for (size_t v = 0; v < bool_array->size; ++v) { | ||
bools.push_back(bool_array->values[v]); | ||
} | ||
return ParameterValue(bools); | ||
} else if (c_param_value->integer_array_value) { | ||
const rcl_int64_array_t * const int_array = c_param_value->integer_array_value; | ||
std::vector<int64_t> integers; | ||
integers.reserve(int_array->size); | ||
for (size_t v = 0; v < int_array->size; ++v) { | ||
integers.push_back(int_array->values[v]); | ||
} | ||
return ParameterValue(integers); | ||
} else if (c_param_value->double_array_value) { | ||
const rcl_double_array_t * const double_array = c_param_value->double_array_value; | ||
std::vector<double> doubles; | ||
doubles.reserve(double_array->size); | ||
for (size_t v = 0; v < double_array->size; ++v) { | ||
doubles.push_back(double_array->values[v]); | ||
} | ||
return ParameterValue(doubles); | ||
} else if (c_param_value->string_array_value) { | ||
const rcutils_string_array_t * const string_array = c_param_value->string_array_value; | ||
std::vector<std::string> strings; | ||
strings.reserve(string_array->size); | ||
for (size_t v = 0; v < string_array->size; ++v) { | ||
strings.emplace_back(string_array->data[v]); | ||
} | ||
return ParameterValue(strings); | ||
} | ||
|
||
throw InvalidParameterValueException("No parameter value set"); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep this here for now 👍
It may be better (in the future) to enforce this at a lower level.
It could be done in the parser:
If the structure always assumes fully qualified name, I guess we could enforce this it in the structure itself by providing structure functions to assign element and reject or add leading slash to the provided node names. This would allow other users of the structure to not have to duplicate that logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Roger. I wasn't sure if I should make a bug on
rcl_yaml_param_parser
about it returning names without a leading slash, or if there will one day be a use case for that (like pushing nodes up a namespace in ros2 launch?). Thanks for the reviews!