Wait for server to be ready in action client tests #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
🤞
/cc @nuclearsandwich |
sloretz
reviewed
Apr 5, 2019
| @@ -273,6 +273,8 @@ TEST_F(TestClient, async_send_goal_but_ignore_feedback_and_result) | |||
| auto action_client = rclcpp_action::create_client<ActionType>(client_node, action_name); | |||
| ASSERT_TRUE(action_client->wait_for_action_server(WAIT_FOR_SERVER_TIMEOUT)); | |||
|
|
|||
| ASSERT_TRUE(action_client->wait_for_action_server(std::chrono::seconds(10))); | |||
There was a problem hiding this comment.
Does adding 10 seconds to WAIT_FOR_SERVER_TIMEOUT on the line above this one also fix the issue?
There was a problem hiding this comment.
XD I didn't even see that.
There was a problem hiding this comment.
So my grep skills failed me.
It looks like it is already waiting for 10 seconds... odd that an additional wait causes the tests to pass 🙁
There was a problem hiding this comment.
The tests were not actually waiting anywhere close to 10 seconds either.
There was a problem hiding this comment.
oooh, my bad. I was working off of the crystal branch, which is missing the wait calls.
|
See #686 instead |
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #683 once backported to
crytsal