Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #637 - Wait for action server before sending goal #686

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Backport #637 - Wait for action server before sending goal #686

merged 1 commit into from
Apr 5, 2019

Conversation

jacobperron
Copy link
Member

@jacobperron jacobperron commented Apr 5, 2019 •
edited by nuclearsandwich
Loading

Resolves #683

@jacobperron jacobperron added the in progress Actively being worked on (Kanban column) label Apr 5, 2019
@jacobperron jacobperron mentioned this pull request Apr 5, 2019
Closed
@sloretz @jacobperron
Wait for action server before sending goal (#637)
39f44f2 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Apr 5, 2019
@nuclearsandwich
Copy link
Member

nuclearsandwich commented Apr 5, 2019 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@nuclearsandwich nuclearsandwich merged commit f7bb006 into crystal Apr 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the backport-637 branch April 5, 2019 18:43
@nuclearsandwich nuclearsandwich removed the in review Waiting for review (Kanban column) label Apr 5, 2019
This was referenced Apr 5, 2019
Closed
Closed
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
@hidmic
Use RCL_RET_* codes only. (ros2#686)
b7dbb3e 
Also, update documentation.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

@nuclearsandwich nuclearsandwich Awaiting requested review from nuclearsandwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobperron @nuclearsandwich @sloretz