[Dashing] backport rclcpp_components_register_node #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*cmake macro to create components for libraries with multiple nodes Signed-off-by: Siddharth Kucheria <kucheria@usc.edu> Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu> Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu> Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
|
Just as a sanity check, are you going to backport all of the demo/example updates for components or just this functionality? |
Just this functionality. I'm using it in a WIP |
|
Moved to in review since I tested this backport works for me in a dashing workspace CI (dashing, testing just rclcpp)
|
mjcarroll
approved these changes
Dec 5, 2019
dirk-thomas
reviewed
Dec 5, 2019
|
Merging, will address #935 (comment) in a new PR |
dirk-thomas
reviewed
Dec 6, 2019
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
* test should check specified number of entities. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * rename function name to be very explicit about the point of the check. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * remove check_graph_state(). Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
…rClock (ros2#935) * Remove JumpHandler copy-implementation from PlayerClock/TimeControllerClock This API was originally envisioned as a way to handle the `seek`/`jump` operation, but that feature ended up being implemented inline in the `Player`. This is not used now, and I do not anticipate using it in the future. Removing as housekeeping - if it is needed later it can always be re-added from history. Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #784, #790, #795 to Dashing for the CMake macro
rclcpp_components_register_node. These 3 PRs are everything in the history ofrclcpp_components_register_node.cmake.https://github.com/ros2/rclcpp/commits/eloquent/rclcpp_components/cmake/rclcpp_components_register_node.cmake