Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement matched event #1083

Conversation

Barry-Xu-2018
Copy link
Contributor

Address ros2/rmw#330

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Barry-Xu-2018 Barry-Xu-2018 force-pushed the topic-add-matched-unmatched-event-support branch from 05c0178 to ec24fe6 Compare March 6, 2023 04:50
@Barry-Xu-2018
Copy link
Contributor Author

Rebase was done.

@fujitatomoya
Copy link
Collaborator

@Barry-Xu-2018 same here, rebase needed.

@Barry-Xu-2018
Copy link
Contributor Author

same here, rebase needed.

Yes. I am doing rebase.

Signed-off-by: Barry Xu <barry.xu@sony.com>
@Barry-Xu-2018 Barry-Xu-2018 force-pushed the topic-add-matched-unmatched-event-support branch from ec24fe6 to 72b85de Compare March 17, 2023 04:46
@Barry-Xu-2018 Barry-Xu-2018 changed the title Add matched & unmatched event support Implement matched event Mar 17, 2023
@mjcarroll mjcarroll merged commit f6d652f into ros2:rolling Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants