Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetTypeDescription service #1139

Merged
merged 4 commits into from
Jul 7, 2023
Merged

GetTypeDescription service #1139

merged 4 commits into from
Jul 7, 2023

Conversation

emersonknapp
Copy link
Contributor

Part of ros2/ros2#1159

Depends on ros2/rcl#1052
Equivalent to ros2/rclcpp#2224
Defines and implements a new component of rclpy.Node that initializes and handles requests for the ~/get_type_description service.

@emersonknapp
Initial commit - added new cpp module extension
1c2c688 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
Service working end to end
4807963 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
Fix tests
63f264b 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp emersonknapp mentioned this pull request Jul 6, 2023
Closed
14 tasks
@emersonknapp
Fix up destroyable implementation and add docstrings
e5bb09a 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp emersonknapp marked this pull request as ready for review July 6, 2023 05:40
@emersonknapp
Copy link
Contributor Author

Pulls: ros2/rcl#1052, #1139
Gist: https://gist.githubusercontent.com/emersonknapp/0ece934b18cc98956ac8cdb2e4f43683/raw/0edfddf4e6bcc841f51aafbd86d30828149f58d0/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12328

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

clalancette
clalancette reviewed Jul 6, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no specific problems with this PR, but it does look like some of the tests are failing. That will need to be fixed.

@emersonknapp emersonknapp mentioned this pull request Jul 6, 2023
Merged
@emersonknapp
Copy link
Contributor Author

emersonknapp commented Jul 6, 2023 •
edited
Loading

Pulls: #1139, ros2/ros2cli#838
Gist: https://gist.githubusercontent.com/emersonknapp/b636f6ea5ccf709b1fc5684de991cb07/raw/99521abc39bdfb6dd39d76e87727d54d198a9cce/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy ros2cli ros2param ros2service
TEST args: --packages-above rclpy ros2cli ros2param ros2service
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12334

  • Linux Build Status
    • Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status
    • Build Status (rerun, no change)

@emersonknapp
Copy link
Contributor Author

emersonknapp commented Jul 7, 2023 •
edited
Loading

Yep, all green. Think we have preexisting flaky test on windows, but I feel confident it is unrelated to this changeset

@clalancette
Copy link
Contributor

Yep, all green. Think we have preexisting flaky test on windows, but I feel confident it is unrelated to this changeset

Yeah, that Windows failure is a flake. This otherwise looks good to me.

@clalancette clalancette merged commit a8d77e6 into ros2:rolling Jul 7, 2023
emersonknapp added a commit to emersonknapp/rclpy that referenced this pull request Jul 7, 2023
@emersonknapp
get_type_description service (ros2#1139)
2a9acee 
* Add get_type_description service

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp emersonknapp mentioned this pull request Jul 7, 2023
Merged
clalancette pushed a commit that referenced this pull request Jul 18, 2023
@emersonknapp
get_type_description service (#1139) (#1140)
cc86878 
* Add get_type_description service

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@sloretz sloretz Awaiting requested review from sloretz sloretz is a code owner

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emersonknapp @clalancette