Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds types to Lifecycle Objects #1338

Merged
merged 39 commits into from
Oct 4, 2024
Merged

Adds types to Lifecycle Objects #1338

merged 39 commits into from
Oct 4, 2024

Conversation

InvincibleRMC
Copy link
Contributor

Builds off of #1235.

InvincibleRMC and others added 17 commits July 31, 2024 11:50
@InvincibleRMC
Add types to wait_for_message.py
1198c24 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Add copyright
a819955 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
re-run CI
6b52d12 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
re-run CI
a6072c1 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Merge branch 'rolling' into wait-for-message
37c87da
@InvincibleRMC
move Handles into _rclpy_pybind11
e39049a 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Move Handles into type stubs:
33cf136 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Move Handles into type stubs
22edf24 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
move [] into string
90f1518 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
fix imports
1019bcc 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
remove extra line
7f22be9 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
puy _rclpy.Publisher in quotes
a61090f 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
fix capitalization
c18a10a 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Add EventHandle Constructor
e45fd69 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Use RuntimeError for context
e010378 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@mergify
Merge branch 'rolling' into wait-for-message
05d5094
@InvincibleRMC
Add TYPE_CHECKING import
47c43f5 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
start lifecycle
19e7afc 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Add types to lifecylce objects
82930c6 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC InvincibleRMC force-pushed the TransitionCallbackReturn branch from 9a8c613 to 82930c6 Compare August 22, 2024 18:32
@InvincibleRMC
move types into string literals
ad431f2 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
use unpack instead
9b55cec 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
flake8
79ad276 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
move Context into string
31f6b9b 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
update create_lifecycle_publisher
31a7734 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
test Unpack tuple
94098d8 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
merge
e570f00 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
use Enum
30d22fe 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
sloretz
sloretz requested changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nitpick!

rclpy/rclpy/lifecycle/node.py Outdated Show resolved Hide resolved
@InvincibleRMC
use RuntimeError
d0e2786 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@sloretz
Copy link
Contributor

sloretz commented Aug 26, 2024

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 26, 2024

update

✅ Branch has been successfully updated

@sloretz
Copy link
Contributor

sloretz commented Aug 26, 2024

Pulls: #1338
Gist: https://gist.githubusercontent.com/sloretz/5ae8c9493cbb2f6cd304e97a2d4ef14c/raw/0cc08b8cc6fe2a9191ebc2969ec1ba7b33589bc5/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14473

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@InvincibleRMC
Mpve Unpack import
b2dca14 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@sloretz
Copy link
Contributor

sloretz commented Aug 26, 2024

Pulls: #1338
Gist: https://gist.githubusercontent.com/sloretz/26afab0411e269cd97f9c479b0507b67/raw/0cc08b8cc6fe2a9191ebc2969ec1ba7b33589bc5/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14474

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@InvincibleRMC
move type inside TYPE_CHECKING block
f6316f9 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
flake8
8efb1a1 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@sloretz
Copy link
Contributor

sloretz commented Aug 30, 2024

@InvincibleRMC Mind fixing the conflict in this one?

@InvincibleRMC
Copy link
Contributor Author

@sloretz The conflicts have been fixed.

@fujitatomoya
Copy link
Collaborator

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 2f9a771 into ros2:rolling Oct 4, 2024
3 checks passed
@InvincibleRMC InvincibleRMC mentioned this pull request Oct 14, 2024
Open
fujitatomoya added a commit that referenced this pull request Oct 14, 2024
@fujitatomoya
Revert "Adds types to Lifecycle Objects (#1338)"
0c66993 
This reverts commit 2f9a771.
@fujitatomoya fujitatomoya mentioned this pull request Oct 14, 2024
Closed
fujitatomoya added a commit that referenced this pull request Oct 14, 2024
@fujitatomoya
Revert "Adds types to Lifecycle Objects (#1338)"
b2f1437 
This reverts commit 2f9a771.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

@ahcorde ahcorde ahcorde approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@InvincibleRMC @sloretz @fujitatomoya @ahcorde