Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executors types #1370

Open
wants to merge 44 commits into
base: rolling
Choose a base branch
from
Open

Executors types #1370

wants to merge 44 commits into from

Conversation

InvincibleRMC
Copy link
Contributor

A redo of #1345 . Assuming this doesn't trigger the mysterious ros2cli flake8 seg fault it should be fine to merge.

InvincibleRMC and others added 30 commits July 31, 2024 11:50
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
InvincibleRMC and others added 9 commits September 4, 2024 11:01
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC InvincibleRMC marked this pull request as draft October 4, 2024 18:06
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC InvincibleRMC marked this pull request as ready for review October 4, 2024 18:56
@InvincibleRMC
Copy link
Contributor Author

@fujitatomoya Since the rhel flake8 seg faults have been fixed can we re-run CI and merge this back in? This should be the same as #1345 which already has approval.

@clalancette
Copy link
Contributor

@fujitatomoya Since the rhel flake8 seg faults have been fixed can we re-run CI and merge this back in? This should be the same as #1345 which already has approval.

To be clear; they are not fixed. They are appearing every night, i.e. https://ci.ros2.org/view/nightly/job/nightly_linux-rhel_release/2086/testReport/ . But I guess at this point it isn't any particular thing we are doing here.

@InvincibleRMC
Copy link
Contributor Author

@fujitatomoya Since the rhel flake8 seg faults have been fixed can we re-run CI and merge this back in? This should be the same as #1345 which already has approval.

To be clear; they are not fixed. They are appearing every night, i.e. https://ci.ros2.org/view/nightly/job/nightly_linux-rhel_release/2086/testReport/ . But I guess at this point it isn't any particular thing we are doing here.

Oh my apologies I saw ros2/ros2cli#932 was closed and assumed it had all been resolved.

@clalancette
Copy link
Contributor

Oh my apologies I saw ros2/ros2cli#932 was closed and assumed it had all been resolved.

No worries. It has popped back up, but I have no idea what causes it or what we should do next. ament/ament_lint#505 fixes it, but is really not ideal. If I have some time this afternoon I might poke at it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants