Lazily import C extensions #422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
|
This is the |
|
Closing, because this is outdated. |
@ivanpauno Is there any open ticket for this? If not, please create one and reference the previous approaches. Also is the branch still needed? |
See #560.
I deleted the branch on one of the PRs, and forgot to do ot in the others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another alternative to #417 #420.
See #420 (comment).
I ended up having a lot of problems with the
qosmodule after applying lazy import, as all the default profiles are constructed at module level.For working around the problem, I did a lot of changes that I don't like at all.
I would rather solve ros2/build_farmer#235 directly in
launch_testing_ros, and figure out later how to avoid having to "hack" the imports while testing inrclpy(which is the root cause of ros2/build_farmer#235).I would rather not merge this PR nor apply lazy import in general, as I believe is creating more problems than solving.