Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support array parameter types #444

Merged
merged 2 commits into from
Oct 21, 2019
Merged

Conversation

BMarchi
Copy link
Contributor

@BMarchi BMarchi commented Oct 16, 2019

Fixes #424. Adds support for double and int python arrays

  • Linux Build Status
  • Arch Build Status
  • macOS Build Status
  • Windows Build Status

Edit: Rerunning jobs

Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
@BMarchi BMarchi requested a review from gonzodepedro October 16, 2019 16:41
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI!

rclpy/test/test_parameter.py Show resolved Hide resolved
Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BMarchi BMarchi requested a review from mjcarroll October 21, 2019 18:01
@BMarchi BMarchi merged commit 11ecd21 into master Oct 21, 2019
@BMarchi BMarchi deleted the BMarchi/support_array_parameter_types branch October 21, 2019 20:32
suab321321 pushed a commit to suab321321/rclpy that referenced this pull request Jan 31, 2020
* Support array parameter types

Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
Signed-off-by: AbhinavSingh <singhabhinav9051571833@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter constructor should accept ParameterValue with array.array types
4 participants