Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip flaky timer test on windows #554

Merged
merged 1 commit into from
May 6, 2020
Merged

Skip flaky timer test on windows #554

merged 1 commit into from
May 6, 2020

Conversation

ivanpauno
Copy link
Member

@ivanpauno
Skip flaky timer test on windows
59feef8 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label May 1, 2020
@ivanpauno ivanpauno requested a review from sloretz May 1, 2020 17:48
@ivanpauno ivanpauno self-assigned this May 1, 2020
@ivanpauno ivanpauno requested a review from hidmic May 6, 2020 16:05
@ivanpauno
Copy link
Member Author

See ros2/system_tests#430 and ros2/system_tests#430 (comment) for some rational of why we have timing issues on Windows.

hidmic
hidmic approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green-ish CI

@ivanpauno
Copy link
Member Author

  • Windows Build Status

@ivanpauno
Copy link
Member Author

The failing test is test_rate, and not test_timer.
The origin of the failure is similar, but I'll improve that one in another PR.

@ivanpauno ivanpauno merged commit 1a76300 into master May 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/skip-flaky-timer-test-on-windows branch May 6, 2020 19:52
@brawner brawner mentioned this pull request Jun 17, 2020
Closed
@dirk-thomas dirk-thomas mentioned this pull request Jul 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

@sloretz sloretz Awaiting requested review from sloretz sloretz is a code owner

Assignees

@ivanpauno ivanpauno

Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanpauno @hidmic