Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Clock.sleep_until #858

Merged
merged 19 commits into from
Dec 15, 2021
Merged

Add Clock.sleep_until #858

merged 19 commits into from
Dec 15, 2021

Commits on Dec 9, 2021

  1. sleep_until works, but need to split other fixes out 

    Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
    @sloretz
    sloretz committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    63b735d View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2021

  1. Merge branch 'master' into rclpy__sleep_until

    @sloretz
    sloretz committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    e3ceee4 View commit details
    Browse the repository at this point in the history

  2. Reduce differences with Master 

    Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
    @sloretz
    sloretz committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    112e856 View commit details
    Browse the repository at this point in the history

  3. flake8 whitespace fix 

    Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
    @sloretz
    sloretz committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    d90902a View commit details
    Browse the repository at this point in the history

  4. Add docstring to sleep_until 

    Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
    @sloretz
    sloretz committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    54a7dc2 View commit details
    Browse the repository at this point in the history

  5. Check ROS Time enabled in C++ to avoid TOCTTOU bug 

    Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
    @sloretz
    sloretz committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    c90a41e View commit details
    Browse the repository at this point in the history

  6. Ditch unused bool return 

    Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
    @sloretz
    sloretz committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    8418310 View commit details
    Browse the repository at this point in the history

  7. Add documentation to Event 

    Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
    @sloretz
    sloretz committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    0a0c5a3 View commit details
    Browse the repository at this point in the history

  8. Duration cast for clocks with poor resolutions 

    Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
    @sloretz
    sloretz committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    4fe3c8d View commit details
    Browse the repository at this point in the history

  9. Satisfy uncrustify 

    Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
    @sloretz
    sloretz committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    7391967 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2021

  1. Remove 'be' 

    Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
    @sloretz
    sloretz committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    9c93f34 View commit details
    Browse the repository at this point in the history

  2. Add missing chrono and mutex includes 

    Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
    @sloretz
    sloretz committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    a07942d View commit details
    Browse the repository at this point in the history

  3. Shorten really long timeouts 

    Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
    @sloretz
    sloretz committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    0530656 View commit details
    Browse the repository at this point in the history

  4. Shorten on_shutdown callback call 

    Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
    @sloretz
    sloretz committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    e6fe67a View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2021

  1. Join threads to avoid sleeping 

    Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
    @sloretz
    sloretz committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    a8ddedf View commit details
    Browse the repository at this point in the history

  2. Document until parameter 

    Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
    @sloretz
    sloretz committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    de582e1 View commit details
    Browse the repository at this point in the history

  3. Larger small amount of time and make sure 10 second tests are quicker 

    Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
    @sloretz
    sloretz committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    8615b7b View commit details
    Browse the repository at this point in the history

  4. Rename event.* to clock_event.* 

    Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
    @sloretz
    sloretz committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    cd90a77 View commit details
    Browse the repository at this point in the history

  5. Event -> ClockEvent 

    Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
    @sloretz
    sloretz committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    dbf83fe View commit details
    Browse the repository at this point in the history