[foxy] fix inverted error code check for action client take #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Chapple <joncpl@gmail.com>
joncppl
force-pushed
the
foxy_action_take_failed
branch
from
e9c10f1
to
721c756
Compare
fujitatomoya
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
mainline has been addressed as following.
rclpy/rclpy/src/rclpy/action_client.cpp
Line 155 in 2c8ffe0
|
CI:
|
|
CI is green, and two approvals, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the comment following the patched line, it appears that the error condition is inverted.
This avoids the thrown exception as explained in #801, and similar scenarios where action servers leave/disappear/restart while rmw_cyclonedds_cpp is the rmw implementation