[Foxy]: Fix type annotation for get_parameters_by_prefix. #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it match Galactic, Humble, and Rolling. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
Still a draft since I haven't tested this yet. |
|
Tested now, so marking as ready for review. I'll also run CI on this. |
|
CI:
|
sloretz
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it match Galactic, Humble, and Rolling.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
Interestingly, this was fixed in Foxy before: #482 . However, it seems to have been reverted later on in #457 , so this updates the Foxy version with what is in later ROS distributions.