Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Methods to retrieve matched counts on publisher and subscriber #155

Merged
merged 4 commits into from
Nov 28, 2018
Merged

Methods to retrieve matched counts on publisher and subscriber #155

merged 4 commits into from
Nov 28, 2018

Conversation

mjcarroll
Copy link
Member

@mjcarroll mjcarroll commented Nov 12, 2018 •
edited
Loading

This provides an API for retrieving the number of matched publishers to a subscription and vice-versa. It is a method to be used with forthcoming additions in creating a port of SubscriberStatusCallback (from ROS 1, see: https://docs.ros.org/api/roscpp/html/namespaceros.html#ac61b99a2913cd421fb915395a67e71a1) for ROS2.

This is different from the existing graph methods, as it should interact directly with a publisher or subscription to retrieve the matched count.

Requires changes in:

@mjcarroll mjcarroll added the in progress Actively being worked on (Kanban column) label Nov 12, 2018
@mjcarroll mjcarroll mentioned this pull request Nov 12, 2018
Merged
@mjcarroll mjcarroll self-assigned this Nov 12, 2018
This was referenced Nov 12, 2018
Merged
Merged
wjwwood
wjwwood reviewed Nov 12, 2018
View reviewed changes
rmw/include/rmw/rmw.h Outdated Show resolved Hide resolved
rmw/include/rmw/rmw.h Outdated Show resolved Hide resolved
rmw/include/rmw/rmw.h Show resolved Hide resolved
jacobperron
jacobperron approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than two typos, LGTM

rmw/include/rmw/rmw.h Outdated Show resolved Hide resolved
rmw/include/rmw/rmw.h Outdated Show resolved Hide resolved
@mjcarroll mjcarroll force-pushed the subscriber_status_callback branch from 0c61d27 to f11eac0 Compare November 26, 2018 22:20
This was referenced Nov 26, 2018
Merged
Merged
@mjcarroll
Copy link
Member Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mjcarroll mjcarroll added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Nov 27, 2018
wjwwood
wjwwood approved these changes Nov 27, 2018
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

rmw/include/rmw/rmw.h Outdated Show resolved Hide resolved
rmw/include/rmw/rmw.h Outdated Show resolved Hide resolved
rmw/include/rmw/rmw.h Outdated Show resolved Hide resolved
rmw/include/rmw/rmw.h Outdated Show resolved Hide resolved
rmw/include/rmw/rmw.h Outdated Show resolved Hide resolved
rmw/include/rmw/rmw.h Outdated Show resolved Hide resolved
@wjwwood @mjcarroll
Apply suggestions from code review
b6c3b57 
Co-Authored-By: mjcarroll <michael@openrobotics.org>
@mjcarroll
Copy link
Member Author

Rerun CI after all changes:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mjcarroll
Copy link
Member Author

Once more with rebased rmw_fastrtps:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mjcarroll mjcarroll merged commit c3b7077 into master Nov 28, 2018
@mjcarroll mjcarroll removed the in review Waiting for review (Kanban column) label Nov 28, 2018
@wjwwood wjwwood deleted the subscriber_status_callback branch December 19, 2018 19:59
@mjcarroll mjcarroll mentioned this pull request Jan 17, 2019
Closed
@dirk-thomas dirk-thomas mentioned this pull request Feb 7, 2019
Closed
dabonnie pushed a commit to aws-ros-dev/rmw that referenced this pull request Apr 2, 2019
@mjcarroll @dabonnie
Methods to retrieve matched counts on publisher and subscriber (ros2#155
81d4c45 
)

* Methods to retrieve matched counts on pub/sub.

* Address reviewer feedback with naming and docs.

* Fix typos.

* Apply suggestions from code review

Co-Authored-By: mjcarroll <michael@openrobotics.org>
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
@AndreasR30 AndreasR30 mentioned this pull request Oct 6, 2022
Closed
@AndreasR30
Copy link

This pull request enables the feature getNumSubscribers() on a publisher but it does not enable your mentioned ROS1 feature SubscriberStatusCallback. Is there any chance to get this feature back in ROS2?

@fujitatomoya
Copy link
Collaborator

@AndreasR30 probably #331 this is what you need? you are very much welcome for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas left review comments

@jacobperron jacobperron jacobperron approved these changes

@wjwwood wjwwood wjwwood approved these changes

Assignees

@mjcarroll mjcarroll

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mjcarroll @AndreasR30 @fujitatomoya @wjwwood @jacobperron @dirk-thomas