Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Add implementation of matching publisher/subscriber counts #310

Merged
merged 4 commits into from
Nov 28, 2018

Conversation

mjcarroll
Copy link
Member

Connects to ros2/rmw#155

@mjcarroll mjcarroll added the in progress Actively being worked on (Kanban column) label Nov 26, 2018
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with minor suggested edits

rmw_connext_cpp/src/rmw_publisher.cpp Outdated Show resolved Hide resolved
rmw_connext_cpp/src/rmw_publisher.cpp Outdated Show resolved Hide resolved
rmw_connext_cpp/src/rmw_subscription.cpp Outdated Show resolved Hide resolved
rmw_connext_cpp/src/rmw_subscription.cpp Outdated Show resolved Hide resolved
Co-Authored-By: mjcarroll <michael@openrobotics.org>
@mjcarroll mjcarroll merged commit 28423c7 into master Nov 28, 2018
@mjcarroll mjcarroll removed the in progress Actively being worked on (Kanban column) label Nov 28, 2018
@mjcarroll mjcarroll deleted the subscriber_status_callback branch November 28, 2018 16:38
dabonnie pushed a commit to aws-ros-dev/rmw_connext that referenced this pull request Apr 3, 2019
* Add unimplemented versions of pub/sub count.

* Static implementation of pub/sub count.

* Finish connext implementation.

* Apply suggestions from code review

Co-Authored-By: mjcarroll <michael@openrobotics.org>
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants