Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding required structs and methods to get a list of publishers or subscribers with their respective qos #186
Adding required structs and methods to get a list of publishers or subscribers with their respective qos #186
Changes from 26 commits
cce521a
8fe5fd2
69744dd
20bedc2
94b27b3
ed9651e
5c5ccbf
06c5d4c
a5e113b
1714008
583687e
91a5668
091988c
ad84fb3
9b22c98
383e4a6
5e0e27f
1d9e1fe
cbd91b3
e24e1f4
272a2dc
c00ad69
3e8f892
a1c35de
747c4c9
06bb093
c82859b
702aef2
8ddb815
6d9675a
2915b73
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like they are allowed? Why not an error case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what error code to use in this case (a generic
RMW_RET_ERROR
?RCL_RET_TOPIC_NAME_INVALID
migrated over tormw
?).Also, this function shouldn't be used for detecting the existence of a topic; that feels like it is encroaching on the purpose of
rmw_get_topic_names_and_types()
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this comment doesn't make since if "non-existent topic" just means a topic that isn't on the graph. I was still thinking an empty string, in which case it should create an error, just like if it violated any of the other rules in the topic name rules set.
I think this can be resolved without changes. Though a follow up question is what happens if the value for
topic_name
violates one of the topic name rules, e.g. empty string, starts with a number, etc.There is already this function:
rmw/rmw/include/rmw/validate_full_topic_name.h
Lines 37 to 90 in 813b94d