This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Make identifier consistent with package name #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 15, 2016
jacquelinekay
added
in review
|
+1 declaring it in the ament index might make sense too for external tool visibility, but I don't think it should have to look up it's own name in the ament index. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the hardcoded string identifier consistent with the package name. This is to avoid a hardcoded map in any situation where we want to match the identifier to the rmw implementation package name, e.g. https://github.com/ros2/rosidl/blob/master/rosidl_generator_py/rosidl_generator_py/import_type_support_impl.py#L17-L20
Perhaps the most proper thing to do would be to register an ament index entry to be used as the identifier (I discussed this with @wjwwood a while ago). This is a simpler fix for now (and avoids introducing a dependency on the ament index and introducing file IO).