Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make rmw_dds_common use rosidl_generator_interfaces normally #12

Merged
merged 5 commits into from
Apr 10, 2020
Merged

make rmw_dds_common use rosidl_generator_interfaces normally #12

merged 5 commits into from
Apr 10, 2020

Conversation

dirk-thomas
Copy link
Member

Fixes #8.

@dirk-thomas dirk-thomas added the bug Something isn't working label Apr 9, 2020
@dirk-thomas dirk-thomas self-assigned this Apr 9, 2020
@dirk-thomas dirk-thomas mentioned this pull request Apr 9, 2020
Merged
ivanpauno
ivanpauno approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This was referenced Apr 9, 2020
Closed
Merged
Merged
@dirk-thomas dirk-thomas mentioned this pull request Apr 10, 2020
Merged
@dirk-thomas
Copy link
Member Author

The last commit swaps the target names to make sure that the interface target has the name of the package. The library uses OUTPUT_NAME to maintain the library name. See ament/ament_cmake#239 for the necessary fix in ament_cmake.

@dirk-thomas dirk-thomas changed the title [WIP] make rmw_dds_common use rosidl_generator_interfaces normally make rmw_dds_common use rosidl_generator_interfaces normally Apr 10, 2020
@ivanpauno
Copy link
Member

The last commit swaps the target names to make sure that the interface target has the name of the package. The library uses OUTPUT_NAME to maintain the library name. See ament/ament_cmake#239 for the necessary fix in ament_cmake.

SGTM, I guess that was affecting ros1_bridge in a weird way.

@dirk-thomas
make rmw_dds_common use rosidl_generator_interfaces normally
cb2ade4 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas
switch from .idl to .msg
2ad5bcb 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas
interface target must have the name of the package
cfc1b8a 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas force-pushed the dirk-thomas/avoid-generators-depend-on-rmw branch from 7afc7ce to cfc1b8a Compare April 10, 2020 16:09
@dirk-thomas
fix rebase
f6c447e 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas
fix rebase - take 2
7377cba 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas merged commit d7f6621 into master Apr 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/avoid-generators-depend-on-rmw branch April 10, 2020 20:44
@ivanpauno ivanpauno mentioned this pull request Apr 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

breaks building ros1_bridge
2 participants
@dirk-thomas @ivanpauno