remove dependency on rmw_implementation #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanpauno
approved these changes
Apr 9, 2020
| # option() | ||
| string(TOUPPER "${typesupport_type}" typesupport_type_upper) | ||
| if(NOT "$ENV{STATIC_${typesupport_type_upper}}" STREQUAL "") | ||
| string(REPLACE ":" ";" STATIC_${typesupport_type_upper} "$ENV{STATIC_${typesupport_type_upper}}") |
There was a problem hiding this comment.
In this case, the ENV variable is overriding the compile option if provided?
Is that the expected behavior?
There was a problem hiding this comment.
It is the same behavior we are using for RMW_IMPLEMENTATIONS.
dirk-thomas
changed the title
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
force-pushed
the
dirk-thomas/avoid-generators-depend-on-rmw
branch
from
dac7570 to
2e1f376
Compare
ivanpauno
approved these changes
Apr 10, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
delete-merged-branch
bot
deleted the
dirk-thomas/avoid-generators-depend-on-rmw
branch
jacobperron
added a commit
to ros-infrastructure/bloom
that referenced
this pull request
May 4, 2020
They are not needed from Foxy onwards. The requirement was removed in ros2/rosidl_typesupport#62. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for ros2/rmw_dds_common#12