Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to clarify the use of environment variable RMW_FASTRTPS_USE_QOS_FROM_XML #466

Merged
merged 4 commits into from
Oct 20, 2020

Conversation

JLBuenoLopez
Copy link
Contributor

Explanation about how to use environment variable RMW_FASTRTPS_USE_QOS_FROM_XML can be clearer preventing misunderstandings and issues that some users have reported (#465)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
JLBuenoLopez and others added 4 commits October 20, 2020 16:21
…_XML

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Copy link
Contributor Author

@hidmic,

I have force-pushed to fix the DCO. I have also applied your suggestions.

Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks @JLBuenoLopez-eProsima !

@hidmic hidmic merged commit f7fd0f5 into ros2:master Oct 20, 2020
@MiguelCompany MiguelCompany deleted the updateREADME branch October 21, 2020 05:13
@@ -33,8 +33,12 @@ You can however set it to `rmw_fastrtps_dynamic_cpp` using the environment varia
* Publication mode: `ASYNCHRONOUS_PUBLISH_MODE`

However, it is possible to fully configure Fast DDS (including the history memory policy and the publication mode) using an XML file as described in [Fast DDS documentation](https://fast-dds.docs.eprosima.com/en/latest/fastdds/xml_configuration/xml_configuration.html).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR, but the README still looks misleading to me. Line 35 reads like "it is possible to fully configure Fast DDS using the XML file", which is not the case.

If only History memory policy and Publication mode can be configured with the XML, then I would expect a big warning right here, otherwise issues like #465 will keep piling up.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jcaraban,

I thinks there's been a misuderstanding. It is indeed possible to fully configure Fast DDS using the XML, not just the History memory policy and Publication mode. What the README intends to convey is that to modify those 2 particular QoS, you will need both have a DEFAULT_FASTRTPS_PROFILES.xml file and to set RMW_FASTRTPS_USE_QOS_FROM_XML=1. Else, History memory policy and Publication mode will be set by RMW regardless of what your XML states

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants