Update README to clarify the use of environment variable RMW_FASTRTPS_USE_QOS_FROM_XML #466
Conversation
…_XML Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
JLBuenoLopez
force-pushed
the
updateREADME
branch
from
aed61bd
to
33ffc95
Compare
|
I have force-pushed to fix the DCO. I have also applied your suggestions. |
| @@ -33,8 +33,12 @@ You can however set it to `rmw_fastrtps_dynamic_cpp` using the environment varia | |||
| * Publication mode: `ASYNCHRONOUS_PUBLISH_MODE` | |||
|
|
|||
| However, it is possible to fully configure Fast DDS (including the history memory policy and the publication mode) using an XML file as described in [Fast DDS documentation](https://fast-dds.docs.eprosima.com/en/latest/fastdds/xml_configuration/xml_configuration.html). | |||
There was a problem hiding this comment.
Hi, thanks for the PR, but the README still looks misleading to me. Line 35 reads like "it is possible to fully configure Fast DDS using the XML file", which is not the case.
If only History memory policy and Publication mode can be configured with the XML, then I would expect a big warning right here, otherwise issues like #465 will keep piling up.
There was a problem hiding this comment.
Hi @jcaraban,
I thinks there's been a misuderstanding. It is indeed possible to fully configure Fast DDS using the XML, not just the History memory policy and Publication mode. What the README intends to convey is that to modify those 2 particular QoS, you will need both have a DEFAULT_FASTRTPS_PROFILES.xml file and to set RMW_FASTRTPS_USE_QOS_FROM_XML=1. Else, History memory policy and Publication mode will be set by RMW regardless of what your XML states
Explanation about how to use environment variable
RMW_FASTRTPS_USE_QOS_FROM_XMLcan be clearer preventing misunderstandings and issues that some users have reported (#465)