-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README to clarify the use of environment variable RMW_FASTRTPS_USE_QOS_FROM_XML #466
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
91f62c5
Refs #9608: update README to clarify use of RMW_FASTRTPS_USE_QOS_FROM…
JLBuenoLopez 834d5b3
Apply review corrections
JLBuenoLopez 19ab0a1
Apply suggestions from code review
JLBuenoLopez 33ffc95
Update link to the table that shows the default value
JLBuenoLopez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the PR, but the README still looks misleading to me. Line 35 reads like "it is possible to fully configure Fast DDS using the XML file", which is not the case.
If only History memory policy and Publication mode can be configured with the XML, then I would expect a big warning right here, otherwise issues like #465 will keep piling up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jcaraban,
I thinks there's been a misuderstanding. It is indeed possible to fully configure Fast DDS using the XML, not just the History memory policy and Publication mode. What the README intends to convey is that to modify those 2 particular QoS, you will need both have a
DEFAULT_FASTRTPS_PROFILES.xml
file and to setRMW_FASTRTPS_USE_QOS_FROM_XML=1
. Else, History memory policy and Publication mode will be set by RMW regardless of what your XML states