Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow null arguments in the EventsExecutor parameters (Humble backport) #605

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Allow null arguments in the EventsExecutor parameters (Humble backport) #605

merged 1 commit into from
Jun 2, 2022

Conversation

j-rivero
Copy link
Contributor

Backport of #600

@j-rivero
Allow null arguments in the EventsExecutor parameters
6ee66f6 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero j-rivero requested a review from Blast545 May 11, 2022 18:04
@Blast545 Blast545 mentioned this pull request May 11, 2022
Closed
@Blast545
Copy link
Contributor

@j-rivero Are you backporting the last three commits on master, right?

Maybe the PR title should better reflect that, "Add EventsExecutor API for dynamic_fastrtps" as in the initial PR?

@Blast545
Copy link
Contributor

Blast545 commented May 17, 2022 •
edited
Loading

Full Humble CI, re running, forgot to include fastrtps-dynamic:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit d388d7d into humble Jun 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the jrivero/humble_602_backport branch June 2, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@Blast545 Blast545 Blast545 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-rivero @Blast545 @clalancette