Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macOS build #90

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Fix macOS build #90

merged 2 commits into from
Mar 24, 2023

Conversation

mossmaurice
Copy link
Collaborator

  • Address build issues on macOS from Humble fix #82
    • Call correct destructor in Publisher and Subscriber
    • Fix dependency of name conversion lib

@mossmaurice mossmaurice self-assigned this Mar 14, 2023
@mossmaurice
Copy link
Collaborator Author

mossmaurice commented Mar 14, 2023 •
edited
Loading

@xlla @karthiknit1

Could you test this branch on macOS and see if it fixes the build issues for you? Unfortunately, I don't have a Mac at hand.

@mossmaurice
Fix dependency of name conversion lib (ros2#81)
eb21b0f 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice
Call correct destructor (ros2#81)
fb26a96 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice mossmaurice added the humble Related to ROS 2 Humble label Mar 14, 2023
@mossmaurice mossmaurice merged commit 4134ce2 into ros2:humble Mar 24, 2023
@mossmaurice mossmaurice mentioned this pull request Mar 24, 2023
Closed
@mossmaurice mossmaurice mentioned this pull request Sep 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elBoberido elBoberido elBoberido approved these changes

Assignees

@mossmaurice mossmaurice

Labels
bugfix humble Related to ROS 2 Humble
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mossmaurice @elBoberido