Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward port changes from humble to master branch #98

Merged
merged 8 commits into from
Sep 20, 2023
Merged

Forward port changes from humble to master branch #98

merged 8 commits into from
Sep 20, 2023

Conversation

mossmaurice
Copy link
Collaborator

@mossmaurice mossmaurice commented Sep 16, 2023 •
edited
Loading

@mossmaurice mossmaurice added the rolling Related to ROS 2 Rolling label Sep 16, 2023
@mossmaurice mossmaurice self-assigned this Sep 16, 2023
@mossmaurice mossmaurice force-pushed the cherry-pick-changes-from-humble-to-master branch from 15bf7ed to 8e91fea Compare September 16, 2023 18:34
@mossmaurice
Use new Blueberry v2.0.3 feature request-response and its discovery (r…
deee637 
…os2#84)

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice
Remove cppcheck from linter job and use Ubuntu 22.04
46cbaa6 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice mossmaurice force-pushed the cherry-pick-changes-from-humble-to-master branch 2 times, most recently from 9ec48aa to be9b31d Compare September 16, 2023 21:07
@mossmaurice
Include 'iceoryx_hoofs' legacy header and use 'iox::into' for string
8b34096 
conversion

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice
Fix dependency of name conversion lib (ros2#81)
2ecc4fe 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice
Call correct destructor (ros2#81)
dec1059 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice
Use 'rcutils_get_executable_name' to get the name of the process (ros…
f80bf33 
…2#94)

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice
Set C++ standard in accordance with iceoryx (ros2#93)
41f1820 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice mossmaurice force-pushed the cherry-pick-changes-from-humble-to-master branch from be9b31d to 41f1820 Compare September 16, 2023 22:12
elBoberido
elBoberido reviewed Sep 17, 2023
View reviewed changes
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had a look at the code in general and iceoryx specifics in dept. For ROS specific changes it's better when someone does the reviews instead of relying on my ignorance :)

rmw_iceoryx_cpp/src/internal/iceoryx_deserialize.cpp Show resolved Hide resolved
rmw_iceoryx_cpp/src/internal/iceoryx_deserialize_typesupport_c.hpp Show resolved Hide resolved
rmw_iceoryx_cpp/src/internal/iceoryx_name_conversion.cpp Show resolved Hide resolved
rmw_iceoryx_cpp/src/internal/iceoryx_topic_names_and_types.cpp Show resolved Hide resolved
rmw_iceoryx_cpp/src/internal/iceoryx_topic_names_and_types.cpp Outdated Show resolved Hide resolved
rmw_iceoryx_cpp/src/rmw_service_server_is_available.cpp Outdated Show resolved Hide resolved
rmw_iceoryx_cpp/src/rmw_service_server_is_available.cpp Outdated Show resolved Hide resolved
rmw_iceoryx_cpp/src/rmw_service.cpp Show resolved Hide resolved
rmw_iceoryx_cpp/src/types/iceoryx_client.hpp Outdated Show resolved Hide resolved
rmw_iceoryx_cpp/src/types/iceoryx_server.hpp Outdated Show resolved Hide resolved
@mossmaurice
Copy link
Collaborator Author

@elBoberido This is just a forward port, the changes were already reviewed in #84. Nevertheless, thanks a bunch for your findings 🙏 I addressed your comments. Back to you.

@mossmaurice mossmaurice mentioned this pull request Sep 18, 2023
Closed
7 tasks
@mossmaurice mossmaurice force-pushed the cherry-pick-changes-from-humble-to-master branch 2 times, most recently from bd8db03 to 64bc818 Compare September 18, 2023 09:42
elBoberido
elBoberido reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Like I said before, I cannot tell anything about the ROS specific changes.

@mossmaurice
Address review findings (ros2#84)
ca6df2e 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice mossmaurice force-pushed the cherry-pick-changes-from-humble-to-master branch from 64bc818 to ca6df2e Compare September 20, 2023 10:01
elBoberido
elBoberido approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No warranty for ROS specific changes :)

@mossmaurice mossmaurice merged commit 91080ff into ros2:master Sep 20, 2023
@mossmaurice mossmaurice mentioned this pull request Jan 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elBoberido elBoberido elBoberido approved these changes

Assignees

@mossmaurice mossmaurice

Labels
rolling Related to ROS 2 Rolling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mossmaurice @elBoberido