Switch to rclcpp logging and improve messages #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbovbel
force-pushed
the
improve-logging
branch
2 times, most recently
from
fadf3ae to
ad5d401
Compare
|
Please consider creating two separate pull requests for these two unrelated changes. That will allow both patches to be reviewer easier and move forward independent of each other. |
cottsay
added
requires-changes
in progress
paulbovbel
force-pushed
the
improve-logging
branch
from
ad5d401 to
6314edf
Compare
paulbovbel
changed the title
|
Done |
paulbovbel
force-pushed
the
improve-logging
branch
from
6314edf to
6d4c7f0
Compare
dirk-thomas
reviewed
Mar 1, 2019
paulbovbel
force-pushed
the
improve-logging
branch
from
01b83f3 to
3e344fa
Compare
|
Fixed up PR with requested changes, thanks for the diligence |
dirk-thomas
added
in review
|
|
|
@paulbovbel Please rebase your branch on top of the latest state of the target branch. |
paulbovbel
force-pushed
the
improve-logging
branch
from
8d883ca to
4dc78d5
Compare
|
Done! I accidentally wiped your changes, but I think I've replicated them in 2678029 |
|
|
|
Fixed. |
|
|
Please run the packages tests locally to avoid this extra iteration in the future. |
|
Thanks for the patch. |
Merged
dirk-thomas
reviewed
Apr 3, 2019
| } | ||
|
|
||
| const boost::shared_ptr<ros::M_string> & connection_header = | ||
| ros1_msg_event.getConnectionHeaderPtr(); | ||
| if (!connection_header) { | ||
| printf(" dropping message without connection header\n"); | ||
| RCLCPP_WARN(logger, "Dropping ROS 1 message %s without connection header", ros1_type_name); |
There was a problem hiding this comment.
The non-format argument must not be a std::string. See #182 for the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to rclcpp logging and improve messages (Close #166)