fix log messages #182
Merged
fix log messages #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added
bug
This was referenced Apr 3, 2019
dirk-thomas
force-pushed
the
fix_log_messages
branch
from
bd27669 to
96da3b3
Compare
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
force-pushed
the
fix_log_messages
branch
from
96da3b3 to
4643634
Compare
|
Sorry to disrupt, and this is likely out of scope, but isn't the fact that this compiled a problem on its own? We don't have a choice in C but to use variadic arguments, but on C++ we could do better than that. Just a thought. |
Please feel free to provide a pull request to improve the existing API. |
hidmic
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #181 which is a regression of #167.