Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle launch_testing assertExitCodes correctly #193

Merged
merged 2 commits into from
May 16, 2019
Merged

Handle launch_testing assertExitCodes correctly #193

merged 2 commits into from
May 16, 2019

Conversation

ivanpauno
Copy link
Member

@ivanpauno ivanpauno commented May 15, 2019 •
edited
Loading

Follow-up of #179

@ivanpauno
Correct assertExitCodes usage
53193a3 
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label May 15, 2019
@ivanpauno ivanpauno requested a review from hidmic May 15, 2019 18:08
@ivanpauno ivanpauno self-assigned this May 15, 2019
@ivanpauno ivanpauno changed the title Correct assertExitCodes usage Handle launch_testing assertExitCodes correctly May 15, 2019
@ivanpauno
Copy link
Member Author

ivanpauno commented May 15, 2019 •
edited
Loading

CI:

  • PackagingLinux Build Status

hidmic
hidmic approved these changes May 16, 2019
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI

@ivanpauno
Corrected error
c1a384f 
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno
Copy link
Member Author

new CI:

  • PackagingLinux Build Status

@ivanpauno ivanpauno merged commit f59706e into master May 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/assert-exit-code-usage branch May 16, 2019 15:53
@ivanpauno ivanpauno removed the in review Waiting for review (Kanban column) label May 16, 2019
dhananjaysathe pushed a commit to rapyuta-robotics/ros1_bridge that referenced this pull request Aug 22, 2019
@ivanpauno @dhananjaysathe
Handle launch_testing assertExitCodes correctly (ros2#193)
c102806 
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Signed-off-by: Dhananjay Sathe <dhananjay.sathe@rapyuta-robotics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

Assignees

@ivanpauno ivanpauno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanpauno @hidmic